reswqa commented on code in PR #20216:
URL: https://github.com/apache/flink/pull/20216#discussion_r933460315
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/compression/BlockCompressionTest.java:
##########
@@ -18,32 +18,54 @@
package org.apache.flink.runtime.io.compression;
+import io.airlift.compress.lz4.Lz4Compressor;
+import io.airlift.compress.lz4.Lz4Decompressor;
+import io.airlift.compress.lzo.LzoCompressor;
+import io.airlift.compress.lzo.LzoDecompressor;
+import io.airlift.compress.snappy.SnappyCompressor;
+import io.airlift.compress.snappy.SnappyDecompressor;
+import io.airlift.compress.zstd.ZstdCompressor;
+import io.airlift.compress.zstd.ZstdDecompressor;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import java.nio.ByteBuffer;
import static
org.apache.flink.runtime.io.compression.Lz4BlockCompressionFactory.HEADER_LENGTH;
import static org.junit.Assert.assertEquals;
/** Tests for block compression. */
+@RunWith(Parameterized.class)
public class BlockCompressionTest {
+ @Parameterized.Parameter public static BlockCompressionFactory
compressionFactory;
+
+ @Parameterized.Parameters(name = "compressionFactory = {0}")
+ public static BlockCompressionFactory[] compressionFactory() {
+ return new BlockCompressionFactory[] {
+ new Lz4BlockCompressionFactory(),
Review Comment:
Good suggestion, fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
