dianfu commented on code in PR #20383:
URL: https://github.com/apache/flink/pull/20383#discussion_r933755193
##########
flink-python/pyflink/datastream/formats/csv.py:
##########
@@ -131,7 +131,7 @@ def add_columns_from(self, schema: 'CsvSchema') ->
'CsvSchemaBuilder':
:param schema: Another :class:`CsvSchema`.
"""
self._j_schema_builder.addColumnsFrom(schema._j_schema)
- for field in cast(schema._data_type, RowType):
Review Comment:
Could we update the test cases to cover this method?
##########
flink-python/pyflink/datastream/connectors/file_system.py:
##########
@@ -535,6 +568,51 @@ def for_row_format(base_path: str, encoder: Encoder) ->
'FileSink.RowFormatBuild
return FileSink.RowFormatBuilder(
JFileSink.forRowFormat(JPath(base_path), encoder._j_encoder))
+ class BulkFormatBuilder(object):
+ """
+ Builder for the vanilla FileSink using a bulk format.
+ """
+
+ def __init__(self, j_bulk_format_builder):
Review Comment:
Several methods in the Java BulkFormatBuilder are missing here, e.g.
enableCompact, disableCompact, etc. Is there any reason why not aligning them
here?
##########
flink-python/pyflink/datastream/formats/avro.py:
##########
@@ -63,6 +70,9 @@ class GenericRecordAvroTypeInfo(TypeInformation):
A :class:`TypeInformation` of Avro's GenericRecord, including the schema.
This is a wrapper of
Java org.apache.flink.formats.avro.typeutils.GenericRecordAvroTypeInfo.
Review Comment:
This class is also a public class which will be used by users and so add it
to the __init__.py to expose it?
##########
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/avro/AvroParquetReaders.java:
##########
@@ -51,15 +51,7 @@ public class AvroParquetReaders {
public static <T extends SpecificRecordBase> StreamFormat<T>
forSpecificRecord(
final Class<T> typeClass) {
return new AvroParquetRecordFormat<>(
- new AvroTypeInfo<>(typeClass),
Review Comment:
It seems that you are reverting the changes made in #19956. Are there any
specify reasons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
