masteryhx commented on code in PR #20313:
URL: https://github.com/apache/flink/pull/20313#discussion_r934182431
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -365,4 +401,19 @@ public String toString() {
return "EmptyDiscardStateObject{" + stateHandleID + '}';
}
}
+
+ private boolean preventsDiscardingCreatedCheckpoint(SharedStateEntry
entry) {
+ // explicitly set by the backend, e.g. private state is reused
+ if (entry.preventDiscardingCreatedCheckpoint
+ &&
restoredCheckpointSharingStrategies.containsKey(entry.createdByCheckpointID)) {
+ return true;
+ }
+ // with NO_SHARING strategy, shared state, if any, is bundled inside
the checkpoint folder
+ // noinspection RedundantIfStatement
+ if (NO_SHARING ==
restoredCheckpointSharingStrategies.get(entry.createdByCheckpointID)) {
Review Comment:
Okay, Thanks for the clarification.
You mean that `SharingFilesStrategy` only applys on runtime but not on
recovery ?
If so, why we need to clarify `NO_SHARING` here, Do other strategies also
need to contain these logics ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
