WencongLiu commented on code in PR #20236:
URL: https://github.com/apache/flink/pull/20236#discussion_r935056650
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java:
##########
@@ -375,7 +359,7 @@ public void testShouldWaitForHandlersWhenClosing() throws
Exception {
// Initiate closing RestServerEndpoint but the test handler should
block.
final CompletableFuture<Void> closeRestServerEndpointFuture =
serverEndpoint.closeAsync();
- assertFalse(closeRestServerEndpointFuture.isDone());
+ assertThat(closeRestServerEndpointFuture.isDone()).isFalse();
Review Comment:
Done.
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java:
##########
@@ -385,7 +369,7 @@ public void testShouldWaitForHandlersWhenClosing() throws
Exception {
// Allow handler to close but there is still one in-flight request
which should prevent
// the RestServerEndpoint from closing.
testHandler.closeFuture.complete(null);
- assertFalse(closeRestServerEndpointFuture.isDone());
+ assertThat(closeRestServerEndpointFuture.isDone()).isFalse();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
