Myracle commented on code in PR #20361:
URL: https://github.com/apache/flink/pull/20361#discussion_r935108846
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java:
##########
@@ -248,6 +248,7 @@ public static SessionContext create(DefaultContext
defaultContext, String sessio
executionContext);
}
+ // TODO: Only related to removeJar in test. Remove it once it has no use.
Review Comment:
It is a choice. But the removeJar needs add jar firstly. If the addJar
method is removed, I has to construct another addJar in sessionContestTest.
What do you think about this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
