rkhachatryan commented on code in PR #20152:
URL: https://github.com/apache/flink/pull/20152#discussion_r935341718
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogStorageLoader.java:
##########
@@ -51,6 +55,9 @@ public class StateChangelogStorageLoader {
private static final HashMap<String, StateChangelogStorageFactory>
STATE_CHANGELOG_STORAGE_FACTORIES = new HashMap<>();
+ private static final ConcurrentHashMap<JobID, StateChangelogStorageView<?>>
+ changelogStorageViewsByJobId = new ConcurrentHashMap<>();
Review Comment:
> Agree with move this map to TaskExecutorStateChangelogStoragesManager for
consistent.
I see the two maps are still in different classes (
`StateChangelogStorageLoader.changelogStorageViewsByJobId` and
`TaskExecutorStateChangelogStoragesManager.changelogStoragesByJobId`).
> The current implementation does not consider switching
StateChangelogStorage implementations
IIRC, it **is** possible, after FLINK-23252. Or do you see any obstacles
preventing from switching the implementation?
I don't think it's mandatory though, just want to be on the same page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
