[ 
https://issues.apache.org/jira/browse/FLINK-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481842#comment-15481842
 ] 

ASF GitHub Bot commented on FLINK-4561:
---------------------------------------

Github user shijinkui commented on the issue:

    https://github.com/apache/flink/pull/2459
  
    @StephanEwen I can accept "don't change it unless it is broken". 
    
    I explain why I made such a insipid and too much changes PR. I have such 
habit, that  is the code need continuous improvement and refactor until have no 
any improvement at this time.  That's why i doesn't want to tolerate bad smell 
code.
    
    I think such matter belong to myself' habit. The others like this PR are 
generated conveniently when I read Flink code. These PRs are not important, can 
be close at any time.
    
    :)


> replace all the scala version as a `scala.binary.version` property
> ------------------------------------------------------------------
>
>                 Key: FLINK-4561
>                 URL: https://issues.apache.org/jira/browse/FLINK-4561
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: shijinkui
>
> replace all the scala version(2.10) as a property `scala.binary.version` 
> defined in root pom properties. default scala version property is 2.10.
> modify:
> 1. dependency include scala version 
> 2. module defining include scala version
> 3. scala version upgrade to 2.11.8 from 2.11.7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to