luoyuxia commented on code in PR #20394:
URL: https://github.com/apache/flink/pull/20394#discussion_r937290113
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java:
##########
@@ -441,6 +441,61 @@ public void testCustomPartitionCommitPolicy() throws
Exception {
testStreamingWriteWithCustomPartitionCommitPolicy(TestCustomCommitPolicy.class.getName());
}
+ @Test
+ public void testAddEmptyPartition() throws Exception {
Review Comment:
nit:
```suggestion
public void testWritingNoDataToPartition() throws Exception {
```
##########
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionLoader.java:
##########
@@ -86,6 +86,32 @@ public void loadNonPartition(List<Path> srcDirs) throws
Exception {
overwriteAndMoveFiles(srcDirs, tableLocation);
}
+ /**
+ * The flink job does not write data to the partition, but the
corresponding partition needs to
+ * be created.
Review Comment:
nit:
```suggestion
* be created or updated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
