fredia commented on PR #20404:
URL: https://github.com/apache/flink/pull/20404#issuecomment-1205087894

   > The current PR tries to fix the issue by replacing job cancellation with 
ControlledSource + requestJobResult, right?
   
   Right.
   
   > However, if the refactoring is part of a fix as you mentioned, then this 
renaming is probably out of scope of this PR.
   
   Yes, how about adding another commit? like:
   - 1f1480af49fb6d70895ecb51a4b74a0cf4ee9afd [refactor][state/changelog] 
Complete upload tasks in StateChangeUploadScheduler


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to