reswqa opened a new pull request, #20456:
URL: https://github.com/apache/flink/pull/20456

   ## What is the purpose of the change
   
   In hybrid shuffle mode, subpartition view lock will be acquired by consumer 
thread, and further wait the read lock of MemoryDataManager. But 
MemoryDataManager may acquire write lock to make a global spilling decision, 
and then wait subpartition view lock to get consuming offset. In this case, 
deadlock will occurs.
   
   consumer thread : acqurie subpartition lock -> wait read lock.
   
   upstream thread  : acquire write lock -> wait subpartition lock.
   
   ## Brief change log
   
     - *FileDataManager get consuming offset with lock.*
     - *MemoryDataManager get consuming offset without lock*
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to