wsry commented on code in PR #20350:
URL: https://github.com/apache/flink/pull/20350#discussion_r938058776


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultPartition.java:
##########
@@ -47,6 +49,15 @@ public class IntermediateResultPartition {
     /** Whether this partition has produced some data. */
     private boolean hasDataProduced = false;
 
+    /**
+     * Released {@link ConsumedPartitionGroup}s for this result partition. 
This result partition can
+     * be released if all {@link ConsumedPartitionGroup}s are released.
+     */
+    private final Set<ConsumedPartitionGroup> releasedPartitionGroups = new 
HashSet<>();

Review Comment:
   1. I use a hash set because it can tolerate duplicate releasing, though 
maybe there is no such case currently.
   2. Renamed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to