gyfora opened a new pull request, #339: URL: https://github.com/apache/flink-kubernetes-operator/pull/339
## What is the purpose of the change This PR should be merged only after https://github.com/apache/flink-kubernetes-operator/pull/338 Include the resource class name `FlinkDeployment/FlinkSessionJob` directly in the KuberentesOperatorResourceNamespace metric group and expose it as part of the first component before the metric name. This eliminates the need to add custom logic for any metric to include the resource name and makes it unifies across the codebase. This PR introduces some changes to the reporting of some (previously inconsistently named) metrics: **JmDeploymentStatus metrics** ``` BEFORE: namespace.default.JmDeploymentStatus.READY.Count AFTER: namespace.default.FlinkDeployment.JmDeploymentStatus.READY.Count ``` **JOSDK metrics metrics** ``` BEFORE resource.default.basic-example.JOSDK.Reconciliation.finished.Count namespace.default.JOSDK.FlinkDeployment.reconcile.resource.TimeSeconds AFTER resource.default.basic-example.FlinkDeployment.JOSDK.Reconciliation.finished.Count namespace.default.FlinkDeployment.JOSDK.reconcile.resource.TimeSeconds ``` ## Brief change log - *Include the resource class name `FlinkDeployment/FlinkSessionJob`* - *Remove current manual adding of FlinkDeployment/Sessionjob to metric group* - *Update JOSDK metric logic to always extract the resource class from metadata (improvement in 3.1.0)* - *Update existing tests* ## Verifying this change This change is already covered by existing tests, which have been updated. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no - Core observer or reconciler logic that is regularly executed: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
