WencongLiu commented on code in PR #20451:
URL: https://github.com/apache/flink/pull/20451#discussion_r938471294
##########
flink-table/flink-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/results/ResultSet.java:
##########
@@ -23,16 +23,30 @@
import org.apache.flink.table.catalog.ResolvedSchema;
import org.apache.flink.table.data.RowData;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonSerialize;
+
import javax.annotation.Nullable;
+import java.io.Serializable;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.stream.Collectors;
/** The collection of the results. */
@PublicEvolving
-public class ResultSet {
+@JsonSerialize(using = ResultSetJsonSerializer.class)
+@JsonDeserialize(using = ResultSetJsonDeserializer.class)
+public class ResultSet implements Serializable {
+
+ public static final String FIELD_NAME_RESULT_TYPE = "result_type";
Review Comment:
Removed.
##########
flink-table/flink-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/results/ResultSet.java:
##########
@@ -23,16 +23,30 @@
import org.apache.flink.table.catalog.ResolvedSchema;
import org.apache.flink.table.data.RowData;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonSerialize;
+
import javax.annotation.Nullable;
+import java.io.Serializable;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.stream.Collectors;
/** The collection of the results. */
@PublicEvolving
-public class ResultSet {
+@JsonSerialize(using = ResultSetJsonSerializer.class)
+@JsonDeserialize(using = ResultSetJsonDeserializer.class)
+public class ResultSet implements Serializable {
+
+ public static final String FIELD_NAME_RESULT_TYPE = "result_type";
+
+ public static final String FIELD_NAME_COLUMN_INFOS = "columns";
+
+ public static final String FIELD_NAME_DATA = "data";
+
+ public static final String FIELD_NAME_NEXT_TOKEN = "next_token";
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
