rkhachatryan commented on code in PR #19679:
URL: https://github.com/apache/flink/pull/19679#discussion_r938541673
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFactory.java:
##########
@@ -66,4 +66,32 @@ <N, SV, SEV, S extends State, IS extends S> IS
createInternalState(
@Nonnull StateDescriptor<S, SV> stateDesc,
@Nonnull StateSnapshotTransformFactory<SEV>
snapshotTransformFactory)
throws Exception;
+
+ /**
+ * Creates and returns a new {@link InternalKvState}.
+ *
+ * @param namespaceSerializer TypeSerializer for the state namespace.
+ * @param stateDesc The {@code StateDescriptor} that contains the name of
the state.
+ * @param snapshotTransformFactory factory of state snapshot transformer.
+ * @param allowFutureMetadataUpdates whether allow metadata to update in
the future or not.
+ * @param <N> The type of the namespace.
+ * @param <SV> The type of the stored state value.
+ * @param <SEV> The type of the stored state value or entry for collection
types (list or map).
+ * @param <S> The type of the public API state.
+ * @param <IS> The type of internal state.
+ */
+ @Nonnull
+ default <N, SV, SEV, S extends State, IS extends S> IS createInternalState(
Review Comment:
I agree, separate commit would be more clear.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFactory.java:
##########
@@ -66,4 +66,32 @@ <N, SV, SEV, S extends State, IS extends S> IS
createInternalState(
@Nonnull StateDescriptor<S, SV> stateDesc,
@Nonnull StateSnapshotTransformFactory<SEV>
snapshotTransformFactory)
throws Exception;
+
+ /**
+ * Creates and returns a new {@link InternalKvState}.
+ *
+ * @param namespaceSerializer TypeSerializer for the state namespace.
+ * @param stateDesc The {@code StateDescriptor} that contains the name of
the state.
+ * @param snapshotTransformFactory factory of state snapshot transformer.
+ * @param allowFutureMetadataUpdates whether allow metadata to update in
the future or not.
+ * @param <N> The type of the namespace.
+ * @param <SV> The type of the stored state value.
+ * @param <SEV> The type of the stored state value or entry for collection
types (list or map).
+ * @param <S> The type of the public API state.
+ * @param <IS> The type of internal state.
+ */
+ @Nonnull
+ default <N, SV, SEV, S extends State, IS extends S> IS createInternalState(
Review Comment:
I agree, a separate commit would be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
