wuchong commented on code in PR #19450:
URL: https://github.com/apache/flink/pull/19450#discussion_r938742244
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java:
##########
@@ -218,6 +218,22 @@ public void testPartitionPrunning() throws Exception {
assertThat(rows).hasSize(2);
Object[] rowStrings =
rows.stream().map(Row::toString).sorted().toArray();
assertThat(rowStrings).isEqualTo(new String[] {"+I[2014, 3, 0]",
"+I[2014, 4, 0]"});
+
+ // test the case that prune partition with reading partition from
catalog without filter and
+ // there exists default partition
+ // insert null value for the partition column which will fall into the
default partition
+ batchTableEnv
+ .executeSql(
+ "insert into source_db.test_table_pt_1 values ('2014',
1, null), ('2015', 2, null)")
+ .await();
+ // currently, the expression "is null" is supported
HiveCatalog#listPartitionsByFilter,
Review Comment:
```suggestion
// currently, the expression "is null" is not supported
HiveCatalog#listPartitionsByFilter,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
