lsyldliu commented on code in PR #20442: URL: https://github.com/apache/flink/pull/20442#discussion_r938839276
########## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/ParquetDataColumnReader.java: ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.parquet.vector.reader; + +import org.apache.flink.table.data.TimestampData; + +import org.apache.parquet.bytes.ByteBufferInputStream; +import org.apache.parquet.column.Dictionary; + +import java.io.IOException; + +/** + * The interface to wrap the underlying Parquet dictionary and non dictionary encoded page reader. + */ +public interface ParquetDataColumnReader { + + /** + * Initialize the reader by page data. + * + * @param valueCount value count + * @param in page data + * @throws IOException + */ + void initFromPage(int valueCount, ByteBufferInputStream in) throws IOException; + + /** @return the next Dictionary ID from the page */ + int readValueDictionaryId(); + + /** @return the next Long from the page */ + long readLong(); + + /** @return the next Integer from the page */ + int readInteger(); + + /** @return the next SmallInt from the page */ + int readSmallInt(); + + /** @return the next TinyInt from the page */ + int readTinyInt(); + + /** @return the next Float from the page */ + float readFloat(); + + /** @return the next Boolean from the page */ + boolean readBoolean(); + + /** @return the next String from the page */ + byte[] readString(); Review Comment: Here doesn't exist `StringVector`, so we can't return string directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
