godfreyhe commented on code in PR #20472:
URL: https://github.com/apache/flink/pull/20472#discussion_r939596677
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -960,11 +997,12 @@ protected Collection<RowData>
convertToRowData(DataStructureConverter converter)
final RowData rowData = (RowData)
converter.toInternal(row);
if (rowData != null) {
rowData.setRowKind(row.getKind());
- result.add(rowData);
+ partitionResult.add(rowData);
+ size++;
Review Comment:
The `partitionResult.size()` is the size of a specific partition, while the
`size` is all accepted partitions total size. There is a for-loop at line 961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
