alpinegizmo commented on code in PR #264:
URL: https://github.com/apache/flink-table-store/pull/264#discussion_r939695277
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source
of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo
>}}).
Review Comment:
```suggestion
In order to build the Flink Table Store you need the source code. Either
[download the source of a release]({{< downloads >}}) or [clone the git
repository]({{< github_repo >}}).
```
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source
of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo
>}}).
+
+In addition you need **Maven 3** and a **JDK** (Java Development Kit). Flink
Table Store requires **Java 8** to build.
+
+*NOTE: Maven 3.3.x can build Flink Table Store, but will not properly shade
away certain dependencies. Maven 3.2.5 creates the libraries properly.*
Review Comment:
This is true for Flink -- though work is ongoing to overcome this limitation
-- but is it also true for the Table Store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
