lincoln-lil commented on code in PR #20324:
URL: https://github.com/apache/flink/pull/20324#discussion_r939777681
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinJsonPlanTest.java:
##########
@@ -156,4 +173,43 @@ public void testLegacyTableSourceException() {
ValidationException.class,
"TemporalTableSourceSpec can not be
serialized."));
}
+
+ @Test
+ public void testAggAndLeftJoinWithTryResolveMode() {
+ tEnv.getConfig()
+ .set(
+
OptimizerConfigOptions.TABLE_OPTIMIZER_NONDETERMINISTIC_UPDATE_STRATEGY,
+
OptimizerConfigOptions.NonDeterministicUpdateStrategy.TRY_RESOLVE);
+
+ util.verifyJsonPlan(
+ "INSERT INTO Sink1 "
+ + "SELECT T.a, D.name, D.age "
+ + "FROM (SELECT max(a) a, count(c) c, PROCTIME()
proctime FROM MyTable GROUP BY b) T "
+ + "LEFT JOIN LookupTable "
+ + "FOR SYSTEM_TIME AS OF T.proctime AS D ON T.a =
D.id");
+ }
+
+ @Test
+ public void testAggAndAllConstantLookupKeyWithTryResolveMode() {
Review Comment:
ok
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AsyncLookupJoinITCase.scala:
##########
@@ -268,6 +268,35 @@ class AsyncLookupJoinITCase(
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ @Test
+ def testAggAndAsyncLeftJoinWithTryResolveMode(): Unit = {
Review Comment:
I've added more cases in LookupJoinITCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
