masteryhx commented on PR #19679: URL: https://github.com/apache/flink/pull/19679#issuecomment-1207630691
> Thanks for updating the PR @masteryhx Production code changes LGTM. > > I have some concerns regarding the test coverage, PTAL at the comments. > > Besides that, commit [86bb0c2](https://github.com/apache/flink/commit/86bb0c26adeb93c28b00b1b2bb4c75acf04fe405) seems not belonging to this PR; and commits [d49670b](https://github.com/apache/flink/commit/d49670b67cc5fe32d3f5e5224453e180651929ed) and [05d91de](https://github.com/apache/flink/commit/05d91de53c277ea40f3a92be7a92991a3ef7ed1a) should be merged together. So in the end I think there should be just two commits: > > * [refactor][state] Rename createInternalState to createOrUpdateInternalState > * [[FLINK-23143](https://issues.apache.org/jira/browse/FLINK-23143)][state/changelog] Support state migration for ChangelogStateBackend > > WDYT? I agree. I have also created a seprate pr for updating the documentation about changing changelog from enabling to disabling as you could see https://github.com/apache/flink/pull/20486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
