WencongLiu commented on PR #20451: URL: https://github.com/apache/flink/pull/20451#issuecomment-1207801814
> Thanks @WencongLiu. I think this PR is very close to a mergable state. > > I have rebased the latest master branch, squashed your fixup commits, and made a few minor changes in two new fixup commits. I've also moved the session related api changes to a hotfix commit. > > I have only two remaining issues. > > * I left some of the comments from the previous round of review unresolved, most of which requires updates to the FLIP. @fsk119, could you help confirm them? > * I'm not fully convinced by making `nextResultUri` and `exception` in `FetchResultsResponseBody` required, even when there's not a next result or exception, especially for `exception`. Why do we need this complexity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
