rkhachatryan commented on code in PR #20217:
URL: https://github.com/apache/flink/pull/20217#discussion_r940126766
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -346,12 +376,42 @@ private static ChangelogStateHandleStreamImpl buildHandle(
tuples.add(Tuple2.of(uploadResult.getStreamStateHandle(),
uploadResult.getOffset()));
size += uploadResult.getSize();
}
- return new ChangelogStateHandleStreamImpl(
- tuples,
- keyGroupRange,
- size,
- incrementalSize,
- FsStateChangelogStorageFactory.IDENTIFIER);
+ ChangelogStateHandleStreamImpl jmChangelogStateHandle =
+ new ChangelogStateHandleStreamImpl(
+ tuples,
+ keyGroupRange,
+ size,
+ incrementalSize,
+ FsStateChangelogStorageFactory.IDENTIFIER);
+ if (localRecoveryConfig.isLocalRecoveryEnabled()) {
+ size = 0;
+ List<Tuple2<StreamStateHandle, Long>> localTuples = new
ArrayList<>();
+ for (UploadResult uploadResult : results.values()) {
+ if (uploadResult.getLocalStreamHandleStateHandle() != null) {
+ localTuples.add(
+ Tuple2.of(
+
uploadResult.getLocalStreamHandleStateHandle(),
+ uploadResult.getOffset()));
Review Comment:
The local offset is now passed and saved in `uploadResult`, but not actually
used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
