zoltar9264 commented on code in PR #20152:
URL: https://github.com/apache/flink/pull/20152#discussion_r940167634
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorStateChangelogStoragesManager.java:
##########
@@ -135,28 +148,109 @@ public void releaseStateChangelogStorageForJob(@Nonnull
JobID jobId) {
}
}
+ @Nullable
+ StateChangelogStorageView<?> stateChangelogStorageViewForJob(
+ @Nonnull JobID jobID,
+ Configuration configuration,
+ ChangelogStateHandle changelogStateHandle)
+ throws IOException {
+ if (closed) {
+ throw new IllegalStateException(
+ "TaskExecutorStateChangelogStoragesManager is already
closed and cannot "
+ + "register a new StateChangelogStorageView.");
+ }
+
+ if (!(changelogStateHandle instanceof ChangelogStateHandleStreamImpl))
{
+ return StateChangelogStorageLoader.loadFromStateHandle(
+ configuration, changelogStateHandle);
+ }
Review Comment:
Ok, I will remove that branch and leave an annotation to remind this .
And by the way , I'm trying to add a test as you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
