gaoyunhaii commented on code in PR #20497:
URL: https://github.com/apache/flink/pull/20497#discussion_r940215921
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/processor/DynamicFilteringDependencyProcessor.java:
##########
@@ -84,4 +100,108 @@ protected void visitNode(ExecNode<?> node) {
return execGraph;
}
+
+ private ExecNodeGraph enforceDimSideBlockingExchange(
Review Comment:
Not really, the issue is that if we only change the edge from `dim` to `fact
source`, `dim`, `fact source` and `join` are still connected via pipeline
edges, thus they would still falls into the same region.
Currently we make all the output edges of `dpp node` and its precedent nodes
(namely the `calc` and `dim source`) to be blocking. This might be further
improved with a complex analysis, but in considering of that currently the dpp
node only has two precedent nodes (`calc` and `dim source`) and their outputs
are relatively small, we might postpone the optimization in consideration of
its complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
