Aitozi commented on code in PR #340:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/340#discussion_r940355933
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -262,9 +264,6 @@ private void onMissingDeployment(FlinkDeployment
deployment) {
*/
private void checkIfAlreadyUpgraded(FlinkDeployment flinkDep, Context<?>
context) {
var status = flinkDep.getStatus();
- if (status.getReconciliationStatus().isFirstDeployment()) {
Review Comment:
why here need to be removed? if it's the first deployment, there is no
target generation to compare
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -307,6 +307,10 @@ public static String writeSpecWithMeta(
ObjectNode metadata = internalMeta.putObject("metadata");
metadata.put("generation",
relatedResource.getMetadata().getGeneration());
+ if
(relatedResource.getStatus().getReconciliationStatus().isFirstDeployment()) {
+ metadata.put("firstDeployment", true);
Review Comment:
nit: do you think it's time to improve the metadata's structure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
