zhuzhurk commented on code in PR #20503:
URL: https://github.com/apache/flink/pull/20503#discussion_r940494129


##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -411,7 +411,10 @@ public enum JobStoreType {
                     .withDescription("The timeout in milliseconds for a idle 
slot in Slot Pool.");
 
     /** Config parameter determining the scheduler implementation. */
-    @Documentation.ExcludeFromDocumentation("SchedulerNG is still in 
development.")
+    @Documentation.Section({
+        Documentation.Sections.EXPERT_SCHEDULING,
+        Documentation.Sections.ALL_JOB_MANAGER
+    })
     public static final ConfigOption<SchedulerType> SCHEDULER =

Review Comment:
   I prefer to rename `Ng` to `Default`. I think `Ng` is a legacy name and it 
may confuse users now.
   However, we should still accept the value `Ng` and treat it as `Default` to 
make the change compatible. But we do not need to expose that to users.
   We also need to improve the description of acceptable values to be more 
explanatory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to