rkhachatryan commented on code in PR #20421: URL: https://github.com/apache/flink/pull/20421#discussion_r940512547
########## docs/content/docs/dev/datastream/fault-tolerance/state.md: ########## @@ -474,9 +474,10 @@ ttl_config = StateTtlConfig \ For more fine-grained control over some special cleanup in background, you can configure it separately as described below. Currently, heap state backend relies on incremental cleanup and RocksDB backend uses compaction filter for background cleanup. -##### Cleanup in full snapshot +##### Cleanup in full scan snapshot -Additionally, you can activate the cleanup at the moment of taking the full state snapshot which +Additionally, you can activate the cleanup at the moment of taking the full scan state snapshot (including the canonical savepoint, +or the full/incremental checkpoint of hashmap state-backend, or the full checkpoint of RocksDB state-backend), which Review Comment: Then how about listing the supported combinations explicitly under "supported"? ``` Additionally, you can activate the cleanup at the moment of taking the full scan state snapshot. This is only supported for canonical savepoints and full checkpoints with HashMap and RocksDB state backends. ``` From the current wording (`including ...`) it's not clear to me whether the list is exhaustive or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
