Myasuka commented on code in PR #20405:
URL: https://github.com/apache/flink/pull/20405#discussion_r940884644
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java:
##########
@@ -223,4 +223,27 @@ public StateIncrementalVisitor<K, N, V>
getStateIncrementalVisitor(
throw new UnsupportedOperationException(
"Global state entry iterator is unsupported for RocksDb
backend");
}
+
+ /**
+ * Similar to decimal addition, add 1 to the last digit to calculate the
upper bound.
+ *
+ * @param prefix the starting prefix for seek.
+ * @return end prefix for seek.
+ */
+ protected final byte[] calculateUpperBound(byte[] prefix) {
+ byte[] upperBound = new byte[prefix.length];
+ System.arraycopy(prefix, 0, upperBound, 0, prefix.length);
+ boolean overFlow = true;
+ for (int i = prefix.length - 1; i >= 0; i--) {
+ int unsignedValue = prefix[i] & 0xff;
+ int result = unsignedValue + 1;
+ upperBound[i] = (byte) (result & 0xff);
+ if (result >> 8 == 0) {
+ overFlow = false;
+ break;
+ }
+ }
+ Preconditions.checkArgument(!overFlow, "The upper boundary
overflows.");
Review Comment:
Though RocksDB uses `unsigned` bytes, it will be really strange to treat
`-128` with a single byte as not overflow on the java side.
As I said before, we will not meet the case to write `-128` within
[clipDBWithKeyGroupRange](https://github.com/apache/flink/blob/master/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java#L128).
During the restoring, we cannot change the max parallelism. If we can make the
condition `currentKeyGroupRange.getEndKeyGroup() >
targetKeyGroupRange.getEndKeyGroup()` pass, the max parallelism is larger than
128, which means the `prefixKeyGroupBytes` is 2. Thus, we will get `0x0080` for
the prefix byte array of `127 + 1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
