leonardBang commented on code in PR #20517:
URL: https://github.com/apache/flink/pull/20517#discussion_r941194581
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingAsyncLookupFunction.java:
##########
@@ -124,10 +125,10 @@ public LookupCache getCache() {
}
// --------------------------------- Helper functions
----------------------------
- private void updateLatestLoadTime() {
+ private synchronized void updateLatestLoadTime(long loadTime) {
Review Comment:
```
@Override
public void close() throws Exception {
delegate.close();
if (cacheIdentifier != null) {
LookupCacheManager.getInstance().unregisterCache(cacheIdentifier);
}
}
```
minor: check null before close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
