lincoln-lil opened a new pull request, #20531:
URL: https://github.com/apache/flink/pull/20531

   ## What is the purpose of the change
   FLINK-28848 introduces a new LOOKUP hint to support retry both on sync and 
async lookup, but the async path doesn't works because of two reasons: 1. 
AsyncLookupJoinRunner has a 'stateful' resultFutureBuffer (which is very 
important for performance) bind to each input record (it's non-reenter-able)  
2. can not lookup new value if cache empty values enabled when chained with the 
new AsyncCachingLookupFunction. So this can not be done by directly enabling 
retry on 'AsyncWaitOperator', so similar to sync lookup join with retry, we fix 
this by using a 'RetryableAsyncLookupFunctionDelegator' to support retry.
   
   ## Brief change log
   * fix async lookup it case with retry
   * add new RetryableAsyncLookupFunctionDelegator
   
   ## Verifying this change
   * RetryableAsyncLookupFunctionDelegatorTest
   * AsyncLookupJoinITCase
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
@Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to