[
https://issues.apache.org/jira/browse/FLINK-28767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577843#comment-17577843
]
Shengkai Fang commented on FLINK-28767:
---------------------------------------
After investigation, I find the main cause is when the test thread cancel the
execution, the SqlGatewayService doesn't wait for the execution thread exits.
When the execution thread is interrupted, it will record the error. Here the
test cancels the operation and then fetch the OperationStatus. It means it's
possible to get the InterruptedException or not.
I think we don't need to record the exception if the execution is interrupted
by the users. Users knows what happens.
> SqlGatewayServiceITCase.testCancelOperation failed with AssertionFailedError
> ----------------------------------------------------------------------------
>
> Key: FLINK-28767
> URL: https://issues.apache.org/jira/browse/FLINK-28767
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
> Affects Versions: 1.16.0
> Reporter: Huang Xingbo
> Assignee: Shengkai Fang
> Priority: Critical
> Labels: test-stability
> Fix For: 1.16.0
>
>
> {code:java}
> 2022-07-31T03:32:09.3148584Z Jul 31 03:32:09 [ERROR] Tests run: 16, Failures:
> 1, Errors: 0, Skipped: 0, Time elapsed: 7.268 s <<< FAILURE! - in
> org.apache.flink.table.gateway.service.SqlGatewayServiceITCase
> 2022-07-31T03:32:09.3205977Z Jul 31 03:32:09 [ERROR]
> org.apache.flink.table.gateway.service.SqlGatewayServiceITCase.testCancelOperation
> Time elapsed: 0.008 s <<< FAILURE!
> 2022-07-31T03:32:09.3207151Z Jul 31 03:32:09
> org.opentest4j.AssertionFailedError: expected:
> <org.apache.flink.table.gateway.api.results.OperationInfo@ab4fed9f> but was:
> <org.apache.flink.table.gateway.api.results.OperationInfo@ea9e78d5>
> 2022-07-31T03:32:09.3207956Z Jul 31 03:32:09 at
> org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
> 2022-07-31T03:32:09.3211582Z Jul 31 03:32:09 at
> org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
> 2022-07-31T03:32:09.3212267Z Jul 31 03:32:09 at
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
> 2022-07-31T03:32:09.3212945Z Jul 31 03:32:09 at
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
> 2022-07-31T03:32:09.3213607Z Jul 31 03:32:09 at
> org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
> 2022-07-31T03:32:09.3216761Z Jul 31 03:32:09 at
> org.apache.flink.table.gateway.service.SqlGatewayServiceITCase.testCancelOperation(SqlGatewayServiceITCase.java:245)
> 2022-07-31T03:32:09.3217645Z Jul 31 03:32:09 at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2022-07-31T03:32:09.3218243Z Jul 31 03:32:09 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2022-07-31T03:32:09.3218971Z Jul 31 03:32:09 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 2022-07-31T03:32:09.3219622Z Jul 31 03:32:09 at
> java.lang.reflect.Method.invoke(Method.java:498)
> 2022-07-31T03:32:09.3227901Z Jul 31 03:32:09 at
> org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
> 2022-07-31T03:32:09.3228714Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
> 2022-07-31T03:32:09.3229561Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
> 2022-07-31T03:32:09.3230353Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
> 2022-07-31T03:32:09.3231409Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
> 2022-07-31T03:32:09.3235059Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
> 2022-07-31T03:32:09.3236100Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
> 2022-07-31T03:32:09.3236978Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
> 2022-07-31T03:32:09.3237841Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
> 2022-07-31T03:32:09.3241384Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
> 2022-07-31T03:32:09.3242557Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
> 2022-07-31T03:32:09.3243372Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
> 2022-07-31T03:32:09.3244155Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
> 2022-07-31T03:32:09.3244899Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
> 2022-07-31T03:32:09.3249715Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
> 2022-07-31T03:32:09.3250594Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3251432Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
> 2022-07-31T03:32:09.3252291Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
> 2022-07-31T03:32:09.3253055Z Jul 31 03:32:09 at
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
> 2022-07-31T03:32:09.3256625Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
> 2022-07-31T03:32:09.3257465Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3258297Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
> 2022-07-31T03:32:09.3259062Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
> 2022-07-31T03:32:09.3262851Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
> 2022-07-31T03:32:09.3263723Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3264528Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
> 2022-07-31T03:32:09.3265259Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
> 2022-07-31T03:32:09.3266191Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
> 2022-07-31T03:32:09.3270216Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.executeNonConcurrentTasks(ForkJoinPoolHierarchicalTestExecutorService.java:155)
> 2022-07-31T03:32:09.3271316Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:135)
> 2022-07-31T03:32:09.3272431Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
> 2022-07-31T03:32:09.3273258Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3277605Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
> 2022-07-31T03:32:09.3278454Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
> 2022-07-31T03:32:09.3279180Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
> 2022-07-31T03:32:09.3280019Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3280980Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
> 2022-07-31T03:32:09.3287071Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
> 2022-07-31T03:32:09.3288036Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
> 2022-07-31T03:32:09.3289128Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129)
> 2022-07-31T03:32:09.3290078Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
> 2022-07-31T03:32:09.3294254Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3295128Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
> 2022-07-31T03:32:09.3295912Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
> 2022-07-31T03:32:09.3296679Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
> 2022-07-31T03:32:09.3297504Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
> 2022-07-31T03:32:09.3305416Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
> 2022-07-31T03:32:09.3306251Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
> 2022-07-31T03:32:09.3307191Z Jul 31 03:32:09 at
> org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
> 2022-07-31T03:32:09.3308099Z Jul 31 03:32:09 at
> java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
> 2022-07-31T03:32:09.3308702Z Jul 31 03:32:09 at
> java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> 2022-07-31T03:32:09.3315595Z Jul 31 03:32:09 at
> java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> 2022-07-31T03:32:09.3316450Z Jul 31 03:32:09 at
> java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> 2022-07-31T03:32:09.3317133Z Jul 31 03:32:09 at
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=38962&view=logs&j=a9db68b9-a7e0-54b6-0f98-010e0aff39e2&t=cdd32e0b-6047-565b-c58f-14054472f1be
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
