[
https://issues.apache.org/jira/browse/FLINK-28213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579668#comment-17579668
]
Timo Walther edited comment on FLINK-28213 at 8/15/22 12:02 PM:
----------------------------------------------------------------
[~lsy] I'm not super happy about the changes in StreamExecutionEnvironment:
{code}
// merge PipelineOptions.JARS, user maybe set this option in high level such as
table
// module, so here need to merge the jars from both configuration object
configuration
.getOptional(PipelineOptions.JARS)
.ifPresent(
jars ->
ConfigUtils.mergeCollectionsToConfig(
{code}
This kind of violates the contract of config options. Setting a config option
suddenly becomes a merging operation. Can't we deal with this problem in the
table module directly? We have similar logic in {{TableConfig#addJobParameter}}
for this. Since Flink 1.15, the configuration story in the table module has
improved significantly, so TableConfig has access to global configuration.
was (Author: twalthr):
[~lsy] I'm not super happy about the changes in StreamExecutionEnvironment:
{code}
// merge PipelineOptions.JARS, user maybe set this option in high level such as
table
// module, so here need to merge the jars from both configuration object
configuration
.getOptional(PipelineOptions.JARS)
.ifPresent(
jars ->
ConfigUtils.mergeCollectionsToConfig(
{code}
This kind of violates the contract of config options. Setting a config option
suddenly becomes a merging operation. Can't we deal with this problem in the
table module directly? We have similar logic in {{TableConfig#addJobParameter}}
for this.
> StreamExecutionEnvironment configure method support override pipeline.jars
> option
> ---------------------------------------------------------------------------------
>
> Key: FLINK-28213
> URL: https://issues.apache.org/jira/browse/FLINK-28213
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Configuration
> Affects Versions: 1.16.0
> Reporter: dalongliu
> Assignee: dalongliu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
