syhily commented on code in PR #20567:
URL: https://github.com/apache/flink/pull/20567#discussion_r945945293
##########
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderTestBase.java:
##########
@@ -198,7 +213,7 @@ void
pollMessageAfterTimeout(PulsarPartitionSplitReaderBase<String> splitReader)
String topicName = randomAlphabetic(10);
// Add a split
- seekStartPositionAndHandleSplit(splitReader, topicName, 0);
+ handleSplit(splitReader, topicName, 0, MessageId.latest);
Review Comment:
`seekStartPositionAndHandleSplit` is used for existed topic. `handleSplit`
is used for non-existed topic. The real testing logic is finished by @imaffe. I
don't want to change it until we find it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
