lindong28 commented on code in PR #143:
URL: https://github.com/apache/flink-ml/pull/143#discussion_r947531290
##########
pom.xml:
##########
@@ -548,12 +548,13 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.1</version>
<configuration>
+ <parallel>classes</parallel>
Review Comment:
Do you know why apache/flink does not use parallel=classes? It might be
safer to understand Flink's approach to make sure it is safe to use parallelize
tests across classes before making this change.
##########
pom.xml:
##########
@@ -548,12 +548,13 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.1</version>
<configuration>
+ <parallel>classes</parallel>
+ <useUnlimitedThreads>true</useUnlimitedThreads>
Review Comment:
If the number of classes is much more than the physical cores, would it
cause performance regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
