xintongsong commented on code in PR #20574:
URL: https://github.com/apache/flink/pull/20574#discussion_r948577004
##########
flink-runtime/pom.xml:
##########
@@ -179,6 +179,11 @@ under the License.
<artifactId>flink-test-utils-junit</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-shaded-jackson-module-jsonSchema</artifactId>
+ </dependency>
Review Comment:
I see, so there are two options:
1. We add this dependency at `compile` scope here, so that downstream
modules don't declare it again.
2. We add this dependency as `test` scope here, and the downstream modules
need to declare it again to explicitly include the test-jar.
@WencongLiu, this PR currently goes for Option-1, while I'd in favor of
Option-2 (and IIUC this is also what @zentol described) because it reduces the
size of the production artifact should be more important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
