snuyanzin commented on code in PR #20544: URL: https://github.com/apache/flink/pull/20544#discussion_r948699559
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ConvFunction.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.SpecializedFunction; +import org.apache.flink.table.runtime.functions.BaseConversionUtils; + +import java.nio.charset.StandardCharsets; + +/** Implementation of {@link BuiltInFunctionDefinitions#CONV}. */ +@Internal +public class ConvFunction extends BuiltInScalarFunction { + + public ConvFunction(SpecializedFunction.SpecializedContext context) { + super(BuiltInFunctionDefinitions.CONV, context); + } + + public static StringData eval(StringData input, Number fromBase, Number toBase) { + if (input == null || fromBase == null || toBase == null) { + return null; + } + byte[] bytes = + BaseConversionUtils.conv(input.toBytes(), fromBase.intValue(), toBase.intValue()); + // fromBase cannot be negative, orElse it will return null. + return bytes == null ? null : StringData.fromBytes(bytes); + } + + public static StringData eval(Number input, Number fromBase, Number toBase) { + if (input == null || fromBase == null || toBase == null) { + return null; + } + byte[] bytes = + BaseConversionUtils.conv( Review Comment: Could you please clarify why `BaseConversionUtils` is required and e.g. `java.lang.Long#toString(long, int)` is not sutable here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
