lsyldliu commented on code in PR #20176:
URL: https://github.com/apache/flink/pull/20176#discussion_r950666316
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -555,6 +621,46 @@ private void testUserDefinedFunctionByUsingJar(String
createFunctionDDL, String
tEnv().executeSql(dropFunctionDDL);
}
+ private void testUserDefinedFunctionByUsingJar(FunctionCreator creator,
String dropFunctionDDL)
Review Comment:
ditto
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/FunctionITCase.java:
##########
@@ -199,4 +265,48 @@ private void testUserDefinedFunctionByUsingJar(String
createFunctionDDL, String
// delete the function
tEnv().executeSql(dropFunctionDDL);
}
+
+ private void testUserDefinedFunctionByUsingJar(FunctionCreator creator,
String dropFunctionDDL)
Review Comment:
I think we can delete `testUserDefinedFunctionByUsingJar(String
createFunctionDDL, String dropFunctionDDL)` method, all related test use this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
