Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2510#discussion_r79382231
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java
 ---
    @@ -183,4 +183,24 @@ protected T getNextRecord() throws IOException {
                }
        }
     
    +   public void resetForIterativeTasks() {
    --- End diff --
    
    The already existing 'reset' tries to reset with in the logic of iteration.
    `this.readView.setReadPosition(0);
                this.numRecordsReturned = 0;`
    
    But it does not put back the fullSegments back to the emptySegment. We need 
a much enhanced reset version. Hence I did not want to change the available one 
and hence added a new one.  WDYT?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to