Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2490#discussion_r79404090
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
@@ -971,10 +971,7 @@ public void
testForwardWithAtLeastOneIterationAssumptionForJavac() {
public void reduce(Iterable<Tuple2<Long, Long>> values,
Collector<Long> out) throws Exception {
Long id = 0L;
for (Tuple2<Long, Long> value : values) {
- id = value.f0;
--- End diff --
This change causes a test to fail and should be reverted.
The UdfAnalyzer is a component that inspects the bytecode of user-defined
functions to infer how they access input values. By removing the if condition
(which is not evaluated by the analyzer), the analyzer can better infer the
behavior of the function produces a different output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
