[ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504218#comment-15504218 ]
ASF GitHub Bot commented on FLINK-4610: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2491 This change looks reasonable. Merging this... > Replace keySet/getValue with entrySet in UdfAnalyzerUtils > --------------------------------------------------------- > > Key: FLINK-4610 > URL: https://issues.apache.org/jira/browse/FLINK-4610 > Project: Flink > Issue Type: Improvement > Components: Java API > Affects Versions: 1.1.2 > Reporter: Alexander Pivovarov > Priority: Minor > > Map.keySet + getValue combination is not very efficient > It can be replaced with Map.entrySet to avoid values lookup > Also MapEntry allows to modify MapEntry value while iterating thought the map > using entrySet.iterator -- This message was sent by Atlassian JIRA (v6.3.4#6332)