[
https://issues.apache.org/jira/browse/FLINK-29124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ivan Qing updated FLINK-29124:
------------------------------
Description:
Redundant NotNull checks in function cli/CliFrontend.
{*}getEffectiveConfiguration{*}():
{code:java}
final ExecutionConfigAccessor executionParameters =
ExecutionConfigAccessor.fromProgramOptions(
checkNotNull(programOptions), checkNotNull(jobJars));
{code}
while *ExecutionConfigAccessor.fromProgramOptions* indeed does the notNull check
{code:java}
public static <T> ExecutionConfigAccessor fromProgramOptions(
final ProgramOptions options,
final List<T> jobJars) {
checkNotNull(options);
checkNotNull(jobJars);
...
}
{code}
I have searched other *ExecutionConfigAccessor.fromProgramOptions()* usages,
and all of them do not use checkNotNull in invokion
was:
Redundant NotNull checks in function cli/CliFrontend.
{*}getEffectiveConfiguration{*}():
{code:java}
final ExecutionConfigAccessor executionParameters =
ExecutionConfigAccessor.fromProgramOptions(
checkNotNull(programOptions), checkNotNull(jobJars));
{code}
while *ExecutionConfigAccessor.fromProgramOptions* indeed does the notNull check
{code:java}
public static <T> ExecutionConfigAccessor fromProgramOptions(
final ProgramOptions options,
final List<T> jobJars) {
checkNotNull(options);
checkNotNull(jobJars);
...
} {code}
> Redundant checkNotNull in cli Package
> -------------------------------------
>
> Key: FLINK-29124
> URL: https://issues.apache.org/jira/browse/FLINK-29124
> Project: Flink
> Issue Type: Improvement
> Components: Command Line Client
> Reporter: ivan Qing
> Priority: Not a Priority
>
> Redundant NotNull checks in function cli/CliFrontend.
> {*}getEffectiveConfiguration{*}():
> {code:java}
> final ExecutionConfigAccessor executionParameters =
> ExecutionConfigAccessor.fromProgramOptions(
> checkNotNull(programOptions), checkNotNull(jobJars));
> {code}
> while *ExecutionConfigAccessor.fromProgramOptions* indeed does the notNull
> check
> {code:java}
> public static <T> ExecutionConfigAccessor fromProgramOptions(
> final ProgramOptions options,
> final List<T> jobJars) {
> checkNotNull(options);
> checkNotNull(jobJars);
> ...
> }
> {code}
> I have searched other *ExecutionConfigAccessor.fromProgramOptions()* usages,
> and all of them do not use checkNotNull in invokion
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
