fsk119 commented on code in PR #20665:
URL: https://github.com/apache/flink/pull/20665#discussion_r956991513
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java:
##########
@@ -401,6 +401,19 @@ public TExecuteStatementResp
ExecuteStatement(TExecuteStatementReq tExecuteState
tExecuteStatementReq.isSetConfOverlay()
? tExecuteStatementReq.getConfOverlay()
: Collections.emptyMap();
+ String loggingOperationEnableVar =
+
HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED.varname;
+ if (Boolean.parseBoolean(
+ executionConfig.getOrDefault(
+ loggingOperationEnableVar,
+
HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED
+ .defaultStrVal))) {
+ throw new IllegalArgumentException(
+ String.format(
+ "SqlGateway doesn't support logging for
operation. Please disable"
+ + " it by setting %s to false.",
+ loggingOperationEnableVar));
+ }
Review Comment:
I think it's better we can throw exception if users tries to fetch the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
