JingsongLi commented on code in PR #280:
URL: https://github.com/apache/flink-table-store/pull/280#discussion_r958012117
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/ChangelogWithKeyFileStoreTable.java:
##########
@@ -164,19 +164,22 @@ public TableRead newRead() {
@Override
public TableRead withFilter(Predicate predicate) {
- List<Predicate> predicates = new ArrayList<>();
+ List<Predicate> keyPredicates = new ArrayList<>();
+ List<Predicate> valuePredicates = new ArrayList<>();
for (Predicate sub : splitAnd(predicate)) {
- // TODO support value filter
if (containsFields(sub, nonPrimaryKeys)) {
- continue;
+ valuePredicates.add(sub);
Review Comment:
We should keep all predicates when we can do predicate push down for values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
