[
https://issues.apache.org/jira/browse/FLINK-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597576#comment-17597576
]
Sergey Nuyanzin commented on FLINK-27998:
-----------------------------------------
[~martijnvisser] could you please elaborate about description: it is stated
that need to update to 1.30.0 and in last comment you say 1.31.0
so may be 2 questions to clarify
1. should the description be changed to update to 1.31.0?
2. A set of classes mentioned to removed after upgrade to 1.30.0. I had a look
at the issue they are referring to [1] and it is [2] which was fixed in 1.31.0.
Is it ok to remove them after upgrade to 1.30.0? (may the question is not
actual if finally the task it upgrade to 1.31.0)
[1]
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/calcite/rel/core/Correlate.java#L46
[2] https://issues.apache.org/jira/browse/CALCITE-5107
> Upgrade Calcite version to 1.30
> -------------------------------
>
> Key: FLINK-27998
> URL: https://issues.apache.org/jira/browse/FLINK-27998
> Project: Flink
> Issue Type: Technical Debt
> Components: Table SQL / API, Table SQL / Runtime
> Reporter: Martijn Visser
> Priority: Major
>
> The latest available version of Calcite is currently 1.30. We already need to
> execute the rework that was planned when upgrading to Calcite 1.27
> FLINK-20873 and when upgrading to Calcite 1.28 FLINK-21239
> When doing this upgrade, we should do this to the last available version.
> This is needed to resolve multiple bugs.
> Additional note: Flink currently uses Calcite 1.26.0 which has this note on
> the release page:
> {{Warning: Calcite 1.26.0 has severe issues with RexNode simplification
> caused by SEARCH operator ( wrong data from query optimization like in
> CALCITE-4325, CALCITE-4352, NullPointerException), so use 1.26.0 for
> development only, and beware that Calcite 1.26.0 might corrupt your data.}}
> https://calcite.apache.org/news/2020/10/06/release-1.26.0/
> The following files should be removed from the Flink code base when upgrading
> calcite to 1.30.0
> in `org.apahce.calcite.rel.core`:
> * Correlate
> * Filter
> * Intersect
> * Minus
> * SetOp
> * Sort
> * Union
> * Values
> * Window
> in `org.apahce.calcite.rel.hint`:
> * HintPredicates
> * NodeTypeHintPredicate
> in `org.apahce.calcite.rel.logical`:
> * LogicalCorrelate
> * LogicalFilter
> * LogicalIntersect
> * LogicalMinus
> * LogicalSort
> * LogicalUnion
> * LogicalValues
> * LogicalWindow
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
