Github user StephanEwen commented on the issue:
    Is there a section that describes the design that this follows in more 
detail? I would like to take a look and comment.
    I am a bit skeptical whether this is going in the right direction. For 
example, I see no reason why there should be a `SorterMemoryAllocator`, or any 
specialization for sorters. Ideally, we get also fewer specializations for 
iterative tasks, not more.
    This looks like many specializations and case distinctions. Flink runs in 
critical production settings and this memory allocation stuff is super 
critical, so we can really only merge it when we feel super comfortable that 
this is (1) rock solid and (2) a good design for the future. Otherwise this 
will be a lot of code.
    To achieve that, I think it would help to break this down into finer issues 
and address them one at a time. I can understand that it is hard to slow down 
sometimes, but for critical runtime changes like this one, I think you need to 
adjust to the speed of whoever can really review and merge these fine grained 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to