Grypse commented on code in PR #357:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/357#discussion_r959199026
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -141,41 +148,19 @@ protected void observeJmDeployment(
return;
}
- Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
- if (deployment.isPresent()) {
- DeploymentStatus status = deployment.get().getStatus();
- DeploymentSpec spec = deployment.get().getSpec();
- if (status != null
- && status.getAvailableReplicas() != null
- && spec.getReplicas().intValue() == status.getReplicas()
- && spec.getReplicas().intValue() ==
status.getAvailableReplicas()
- && flinkService.isJobManagerPortReady(effectiveConfig)) {
-
- // typically it takes a few seconds for the REST server to be
ready
- logger.info(
- "JobManager deployment port is ready, waiting for the
Flink REST API...");
- deploymentStatus.setJobManagerDeploymentStatus(
- JobManagerDeploymentStatus.DEPLOYED_NOT_READY);
+ if
(KubernetesDeploymentMode.NATIVE.equals(flinkApp.getSpec().getMode())) {
+ Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
+ if (deployment.isPresent()) {
+ jmDeploymentObserver(deployment.get(), effectiveConfig,
deploymentStatus, flinkApp);
return;
Review Comment:
It's very important to run JM with PVC for working with work-dir[1] to fast
recovery.
1.
https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/resource-providers/standalone/working_directory/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
