[
https://issues.apache.org/jira/browse/FLINK-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505773#comment-15505773
]
ASF GitHub Bot commented on FLINK-4638:
---------------------------------------
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2515#discussion_r79544108
--- Diff:
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ---
@@ -161,7 +161,7 @@
}
if (offHeapAddress >= Long.MAX_VALUE - Integer.MAX_VALUE) {
// this is necessary to make sure the collapsed checks
are safe against numeric overflows
- throw new IllegalArgumentException("Segment initialized
with too large address: " + address
--- End diff --
here `address` has not been initialized yet; should really be
`offHeapAddress`
> Fix exception message for MemorySegment
> ---------------------------------------
>
> Key: FLINK-4638
> URL: https://issues.apache.org/jira/browse/FLINK-4638
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0, 1.1.2, 1.1.3
> Reporter: Liwei Lin
> Priority: Trivial
>
> Please see the code snip below:
> {code:title=MemorySegment.java|borderStyle=solid}
> if (offHeapAddress >= Long.MAX_VALUE - Integer.MAX_VALUE) {
> throw new IllegalArgumentException("Segment initialized with too large
> address: " + address // here address has not been initialized yet; should
> really be offHeapAddress
> + " ; Max allowed address is " + (Long.MAX_VALUE - Integer.MAX_VALUE -
> 1));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
