mas-chen commented on code in PR #20215:
URL: https://github.com/apache/flink/pull/20215#discussion_r960131874
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/MultipleFuturesAvailabilityHelper.java:
##########
@@ -57,13 +57,17 @@ public CompletableFuture<?> getAvailableFuture() {
return availableFuture;
}
+ public int getSize() {
+ return futuresToCombine.length;
+ }
+
public void resetToUnAvailable() {
if (availableFuture.isDone()) {
availableFuture = new CompletableFuture<>();
}
}
- private void notifyCompletion() {
+ public void notifyCompletion() {
Review Comment:
That's a good point! We can pursue a solution that avoids using this class
since we only really need to maintain 1 future at a time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
