ASF GitHub Bot commented on FLINK-4563:

GitHub user ex00 opened a pull request:


    [FLINK-4563] [metrics] Delimiter should be configured per reporter

    It is my fix FLINK-4563. I want fix this issue, please send me your 
comments about this implementation.
    I could assign to me 
[issue](https://issues.apache.org/jira/browse/FLINK-4564) in jira?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ex00/flink FLINK-4564

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2516
commit 381026fbacd1616007c8ddb298853b64b98734df
Author: Anton Mushin <anton_mus...@epam.com>
Date:   2016-09-20T09:29:31Z

    [FLINK-4563] [metrics] Delimiter should be configured per reporter


> [metrics] scope caching not adjusted for multiple reporters
> -----------------------------------------------------------
>                 Key: FLINK-4563
>                 URL: https://issues.apache.org/jira/browse/FLINK-4563
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
> Every metric group contains a scope string, representing what entities 
> (job/task/etc.) a given metric belongs to, which is calculated on demand. 
> Before this string is cached a CharacterFilter is applied to it, which is 
> provided by the callee, usually a reporter. This was done since different 
> reporters have different requirements in regards to valid characters. The 
> filtered string is cached so that we don't have to refilter the string every 
> time.
> This all works fine with a single reporter; with multiple however it is 
> completely broken as only the first filter is ever applied.

This message was sent by Atlassian JIRA

Reply via email to