xuyangzhong commented on code in PR #20705:
URL: https://github.com/apache/flink/pull/20705#discussion_r961392269
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/JoinHintResolver.java:
##########
@@ -172,21 +187,49 @@ && matchIdentifier(option, rightName.get())) {
private void validateHints() {
Set<RelHint> invalidHints = new HashSet<>(allHints);
invalidHints.removeAll(validHints);
+ String errorPattern;
+
+ // firstly, check the unknown table (view) names in hints
+ errorPattern =
+ "The options of following hints cannot match the name of "
+ + "input tables or views: %s";
+ StringBuilder errorMsgSb = new StringBuilder();
+ AtomicBoolean containsInvalidOptions = new AtomicBoolean(false);
Review Comment:
In the following function "xxx.stream().filter", the value
"containsInvalidOptions" will be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
